Mike Purvis
Mike Purvis
Looks great, I dig it! +1
The main consumer of `diagnostics_agg` is the GUI, but I think its _purpose_ is to supply a single diagnostic snapshot which doesn't require opening a socket to every node which...
That seems reasonable to me.
Looks reasonable to me. Something similar we've experimented with is a folding analyzer— if error X is set, downgrade errors Y and Z, so that there isn't user confusion about...
It looks good to me, but I'm not the maintainer of this repo, just an interested third party.
Preference for build tree vs. mkdtemp?
Oh I see— the issue being that we don't know where the build space is in this context, and it might not even exist, since you could run the nosetests...
@tfoote This is needed for the Nix build as well, since it's very strict about dependencies. ---- Oh ugh, I see the real issue here— it's a mutual build-depend since...