Mihai PLESA

Results 24 comments of Mihai PLESA

I've got a PR pending at https://github.com/brave/brave-core/pull/6927 if anyone wants to try building. It needs more testing from our side and a few fixes.

Reopening as this broke some things. Have to reimplement.

Having this in will be great.

@arkadiyt let us know if we can help getting this in.

@joe-niland can we try tests again?

Ok, should work now @joe-niland.

I've tested with https://github.com/cloudposse/terraform-aws-ecs-web-app/compare/master...mihaiplesa:terraform-aws-ecs-web-app:master and setting `codebuild_enabled` to `false`. One last possible change would be to replace `[0]` with `.*.`.

Ugh, for using `aws_s3_bucket_acl` we need AWS provider v4 and this module has `>= 2.0` so we'd break compatibility if we merge this. Similar in https://github.com/cloudposse/terraform-aws-codebuild. Can we just merge...