assign efs volumes configuration to efs_volume variable in ecs_alb_se…

[oajara]

what

Creates a separated variable for EFS volumes.

why

• The way terraform-aws-ecs-web-app defines and uses the EFS volumes with the terraform-aws-ecs-alb-service-task module is not working correctly and the EFS volume is not being set in the resulting task definition.
• By separating EFS volumes and Docker volumes they can be assigned to the docker_volumes and efs_volumes as expected by the module.

[joe-niland]

@oajara I think this makes sense, in that it matches the approach taken in terraform-aws-ecs-alb-service-task

I would set this PR to ready for review.

[jamengual]

/test all

[mihaiplesa]

Looking forward for this to get in.

[jamengual]

/test all

[jamengual]

This is a breaking change. You are modifying an existing variable and dissecting it into two which is not backward compatible.

I can see what was done in the terraform-aws-ecs-alb-service-task so I guess it is ok to replicate this over to here.

[jbcom]

I just pushed https://github.com/cloudposse/terraform-aws-ecs-web-app/pull/213 which maintains backwards compatibility and adds support for FSX volumes.