aws_public_ips icon indicating copy to clipboard operation
aws_public_ips copied to clipboard

Multi region support

Open kadaan opened this issue 6 years ago • 14 comments

  • Display progress while running by specifying --progress
┌ [+] Probing APIGateway...
├── [+] ap-northeast-1
├── [+] ap-northeast-2
├── [+] ap-south-1
├── [+] ap-southeast-1
├── [+] ap-southeast-2
├── [+] ca-central-1
├── [+] eu-central-1
  • Include tag data in ec2 records by adding --include_tags name
  • Multi-region support. Defaults to the region specified by AWS_DEFAULT_REGION or AWS_REGION. Many regions can be specified. all will include all regions.

kadaan avatar Jan 31 '19 03:01 kadaan

Pull Request Test Coverage Report for Build 140

  • 149 of 154 (96.75%) changed or added relevant lines in 13 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.8%) to 98.246%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/aws_public_ips/utils.rb 33 38 86.84%
<!-- Total: 149 154
Totals Coverage Status
Change from base Build 136: -1.8%
Covered Lines: 280
Relevant Lines: 285

💛 - Coveralls

coveralls avatar Jan 31 '19 03:01 coveralls

Pull Request Test Coverage Report for Build 99

  • 119 of 151 (78.81%) changed or added relevant lines in 13 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-11.3%) to 88.652%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/aws_public_ips/cli.rb 8 11 72.73%
lib/aws_public_ips/cli_options.rb 38 46 82.61%
lib/aws_public_ips/utils.rb 17 38 44.74%
<!-- Total: 119 151
Totals Coverage Status
Change from base Build 97: -11.3%
Covered Lines: 250
Relevant Lines: 282

💛 - Coveralls

coveralls avatar Jan 31 '19 03:01 coveralls

@arkadiyt Can I get some feedback?

kadaan avatar Jan 31 '19 20:01 kadaan

@kadaan thanks for the PR! I'll try to get to this tonight

arkadiyt avatar Feb 01 '19 01:02 arkadiyt

What's happening with this? I would love to see this merged!

eamonnfaherty avatar Mar 28 '19 21:03 eamonnfaherty

Me too :)

kadaan avatar Mar 28 '19 21:03 kadaan

This PR is working great for me so far. The only small difference to get it working was needing to run gem install tty-spinner. Thanks arkadiyt and @kadaan for your work here.

SmeegeSec avatar Oct 22 '19 21:10 SmeegeSec

I've been using this PR for a while now. I've got a version that's based on the 1.0.7 version of master here: https://github.com/breser/aws_public_ips/tree/multi_region_support

breser avatar Mar 10 '20 19:03 breser

@kadaan Hiya, can I help with getting this PR merged?

kiwiz avatar May 14 '20 23:05 kiwiz

@kiwiz Go for it!!!

kadaan avatar May 15 '20 02:05 kadaan

@kadaan Thanks for your blessing (and my bad, thought you were the maintainer) @arkadiyt Hiya, what work is necessary to get this merged?

kiwiz avatar May 18 '20 17:05 kiwiz

@arkadiyt let us know if we can help getting this in.

mihaiplesa avatar Feb 22 '21 08:02 mihaiplesa

@kadaan @arkadiyt Any help we can provide to get this merged? This is really useful for us!

weisslj avatar Apr 29 '21 15:04 weisslj

Pity this request is not merged, I'm using it for several months and it is so useful.

f-ivasic avatar Oct 04 '23 13:10 f-ivasic