Michael Kochell

Results 694 comments of Michael Kochell

Making sure we take into account the server's `SiteURL` will make sure we use the correct path. Please see this PR for a similar fix https://github.com/mattermost/mattermost-plugin-github/pull/459

@svenefftinge It would be interesting if the workflow could match the style of docker image development, how you can iterate on a dockerfile as it caches the execution of each...

@hanzei Is there a benefit to setting up webhooks via plugin other than for the subscriptions feature? If not, I propose we keep the webhooks an implementation detail and have...

> michael had a suggestion for changing the command to `/github webhook check org/repo`. Sorry when I said "It seems like it should be `/webhook check org/repo` since we're only...

Hi @tmotyl, there is a plugin setting "Apply plugin to updated posts as well as new posts". Do you have this setting enabled?

We may already be doing this, but we should make sure to `LogDebug` when we are avoiding a post creation due to the exclude feature

> Hi @mickmister, > > ```go > type StatusFlags struct { > userNotified bool // TO STORE: No post was made from the webhook call on any subscription > subscriptionSkipped...

I was looking at the code that adds the `--exclude` flag, and noticed a few issues: https://github.com/mattermost/mattermost-plugin-github/blob/40e7fcf8bdfa2f49bae44b214ed96588ffe6c4df/server/plugin/command.go#L637-L659 1. We are only adding the `--exclude` flag when `config.GitHubOrg` is set. This...

Note: The original feature was reverted here https://github.com/mattermost/mattermost-plugin-github/pull/529, so master is currently not affected by this

@ijansky Do you mind posting a screenshot of what this feature looks like?