Michael Kochell

@srgyrn Awesome work! This is a great performance improvement and simplifies the communication with GitHub. I have one comment on the functionality behavior. Before this PR, the functionality worked like:...

@jespino Do you have any thoughts on the change in data structure for the i18n configs?

@sibasankarnayak This is causing issues with log spam on a customer's server, as seen in the linked thread in the description. I'm thinking we have a few options here: -...

> * I have not handled the case where the token is both expired and revoked. Here, `p.checkAndRefreshToken` attempts to refresh the token and the call to `src.Token` fails. However,...

> > What is the side effect of "not handling the case where the token is both expired and revoked"? Note that the plugin's API is called multiple times when...

> > Are we getting the "invalid token" error from GitLab in this case? Shouldn't we just delete it from our database and tell the user about it like usual?...

@MatthewDorner Could we have a wrapper function around the http handler functions? https://github.com/mattermost/mattermost-plugin-gitlab/blob/c5d107ec3962fd8ba53596d595c703922bd6f3e3/server/api.go#L52 We can rename `checkAuth` to `checkMattermostAuth`, then make a similar `checkGitlabAuth` function for certain routes. Note that...

> @mickmister Think it would work to use a wrapper or decorator around the GitLab client calls? Otherwise, every method that makes GitLab calls must call `checkAndRefreshToken` in its setup...

> The Golang `oauth2` library apparently auto-refreshes the token, but doesn't give you the new token back Doesn't the current solution for auto-refreshing the token in this project rely on...

@MatthewDorner Sorry it's difficult for me to grasp based on our discussion here. What are the remaining items to resolve here? This PR adds a lot of value to the...