Michael Kochell

Results 694 comments of Michael Kochell

Hi @MatthewDorner Sorry for the late response here. Would you still like to take this ticket?

@MatthewDorner The idea behind the `permanentDelete` is to allow the plugin to use its own discretion to determine the level of data deletion it should perform itself. Maybe this isn't...

@MatthewDorner Thanks for the thorough investigation :+1: Looks like the enterprise code is calling this: ```go app.UpdateActive(c, existingUser, false) ``` So as long as it's handled in that case we...

LGTM, thanks for the quick response @asaadmahmood! Ticket is now up for grabs

I'd like to point out that this could be applicable on all 4 categories of data shown on the LHS (open PRs, PR reviews, assignments, and notifications).

Hi @gsagula, It seems that the `success = true` line may be a bug. This line was introduced before the switch to using `api.KVCompareAndSet`, which gives us a success return...

> Something like a token bucket should probably be enough. WDYT? Looks like a great solution, looking forward to the implementation! > I'm still getting familiar with the design. Is...

@DHaussermann @dipak-demansol @sibasankarnayak We are currently unsure if https://github.com/mattermost/mattermost-plugin-autolink/issues/188 should block this release. We would like to release this in a week if we are still unsure.