Michał Dudak comments

Results 443 comments of


                                            Michał Dudak

[RFC] Customization of unstyled components

> I think the question here is "do you want MUI Base to support subcomponents customization?" No. We don't want to assume any particular shape of slot components. Specifically, we...

[RFC] The way to override components and slots

So, if I understand this correctly, you're proposing that the `components.x` is a shorter way of writing `slotProps.x.component`, yes?

[RFC] The way to override components and slots

Generally, I see two changes are proposed here: 1. Change (or settle on) the interpretation of the `component` prop, so that it is used to customize the leaf element (similarly...

[RFC] The way to override components and slots

> What I meant is that in terms of behavior it will behave the same. Not necessarily. The current pattern in Material UI uses the `as` prop to modify the...

[Select][base] Set the onChange's event.target.value

Sure, go ahead!

[Tabs][base] Expose valueToIndex from useTabsList in mui/base

Thanks for your input. The internals (and a bit of the API surface area) of the tabs will likely change. We'd like to move away from `cloneElement` and instead use...

[Tabs][base] Expose valueToIndex from useTabsList in mui/base

Sure. We'll also include the proper note in the changelog as it'll likely be a breaking change.

[TabScrollButton] Add ability to change left and right icons

Regression tests fail because they in your branch use the old SDK that's not supported anymore. Please marge in the latest master.

[Joy] Add `CircularProgress` component

There is a growing list of components we should create in MUI Base :) Let's set priorities on the next product meeting.

[Alert] Add `components` and `componentsProps` props to allow close action overrides

Could you please merge in the latest master? This should solve the failing regression tests issue.