[TabScrollButton] Add ability to change left and right icons

[pratikkarad]

Closes #33235

• [X] I have followed (at least) the PR section of the contributing guide.

[mui-bot]

Netlify deploy preview

https://deploy-preview-33863--material-ui.netlify.app/

@material-ui/core: parsed: +0.14% , gzip: +0.14% @material-ui/lab: parsed: +0.28% , gzip: +0.24%

Bundle size report

Details of bundle changes

Generated by :no_entry_sign: dangerJS against 278b2bbc3a3f037715fa21a3411eb9da77ea2b4c

[pratikkarad]

Sure, no problem 👍🏻

[pratikkarad]

Hi @mnajdova, I made changes in PR as suggested. I also tested locally it is working fine but failing on ci/circleci. Could you please advise, what is going wrong? Thanks!

[pratikkarad]

Hi @mnajdova, As per my understanding, we have removed the initialization of components prop from Tab.js

components = {
  ScrollButtonStart: KeyboardArrowLeft,
  ScrollButtonEnd: KeyboardArrowRight,
},

to

components = {},

that's why Argo is complaining about this because the start & end icon was hard coded before. Now it is trying to compare the before and after snapshots.

[pratikkarad]

I tried initializing the component prop in Tab.test.js, still, it is failing at circleci regression test.

Hi @mnajdova, As per my understanding, we have removed the initialization of components prop from Tab.js

components = {
  ScrollButtonStart: KeyboardArrowLeft,
  ScrollButtonEnd: KeyboardArrowRight,
},

to

components = {},

that's why Argo is complaining about this because the start & end icon was hard coded before. Now it is trying to compare the before and after snapshots.

As I suggested, I think initializing the component prop with default Icons may solve the issue. Any suggestions on this? cc: @mnajdova, @michaldudak

[michaldudak]

Regression tests fail because they in your branch use the old SDK that's not supported anymore. Please marge in the latest master.

[pratikkarad]

Hi @mnajdova, I've updated PR, PTAL.

[safeamiiir]

Hi @mnajdova, I was trying to find an issue to work on. I found this PR only needs tiny name change, Can I push new commit into this branch and make it done?

As I understand we only need a naming change: component -> slot componentProps -> slotProps

[ZeeshanTamboli]

@safeamiiir Please go ahead.