Michał Dudak

Results 443 comments of Michał Dudak

For the record, the demo loader used in Base UI docs has this functionality built-in already, so once we propagate it to other repos, it should still work fine.

@benface The Portal part also handles mounting and unmounting popups. We made it that way, as usually it's desired to render popups outside of the rest of the application's DOM...

@benface, technically, the Trigger part is not required, as you can control the menu's open state from the outside (as in https://codesandbox.io/p/sandbox/agitated-kare-94567v?file=%2Fsrc%2FApp.tsx%3A16%2C22), but I assume this will be a quite...

> FloatingTree can't generalize between different floating components (e.g. Popover openOnHover -> Menu openOnHover will close the Popover unexpectedly). It is possible that dot point 1 would solve this if...

I'd intuitively expect the DownArrow to open the menu, as in Menubar. Also, when the menu is open, the focus should be placed within the popup.

Radix works slightly better, as when the popup is open, it allows focusing its contents with the DownArrow while our solution focuses the next nav menu item. I like interactions...

There are a couple of things that can be improved regarding keyboard navigation: - I'd expect the DownArrow to open the menu, not to move between triggers (especially if I...

Focus restoration bug: 1. tab into the first trigger 2. click away to close the menu 3. hover over items 4. when you hover over the Link, the previous Trigger...

The Search in your example should be defined as a client component. Adding `'use client';` at the top solves the issue.

There's a README in the packages\mui-icons-material directory. However, the script to execute has a few issues and requires manual fixes.