Michał Dudak

Results 443 comments of Michał Dudak

Thanks! During testing, I found one behavior I'm not sure about. When no tags are selected (the cursor is visible), pressing Delete removes the last tag (just like the Backspace...

:+1: It does work well now when the cursor is behind tags. But when a tag is focused, Delete should delete **the focused tag itself**, not the next one.

Try merging in the latest master. It should help to solve the problems with Argos and E2E tests. Could you also add another unit test that would verify if no...

Just for the record, as we've discussed in one of the meetings - @siriwatknp is going to prepare a POC in Joy, and once we consider the API good enough,...

> There are different types of menus. Having a single component called Menu is maybe an oversimplification. For example, in Radix we have Context Menu, Navigation Menu, Dropdown Menu, Select....

Perhaps we should ask the developers what API they'll prefer to use.

Sure, if that's what our users want, I'm fine with it. But then, let's rethink other components' API as well because I wouldn't like to have many different customization patterns...

@siriwatknp, @oliviertassinari One more question about options 4 and 5 - how do you envision setting the menu button or items' props conditionally, based on the state of the menu?...

It is very important for Base components, though. And in this case, there is no possibility to use `sx` or a theme.

Having the "one DOM element per component" pattern makes `slots` and `slotProps` obsolete, IMO.