Michael Bromley

Results 751 comments of Michael Bromley

I got sucked down a deep rabbithole on this today. I think I'm pretty close to done, but this is much more subtly complex than I first thought. I established...

I have realized that there is a simpler solution to a major practical problem solved by this PR: lack of priority mechanism. Currently, (and this is a real world example)...

Priority support implemented here: https://github.com/vendure-ecommerce/vendure/commit/90b5e05ec345a3c91ab6ce0a09f24d8b51b37364

Hi, Thanks for this contribution! Just an update: right now I am focusing on the next tasks for the v3.1 release, but I definitely intend to properly review this and...

Let's label it as a feature, but low prio is right.

This is actually implemented at the data-model level: https://github.com/vendure-ecommerce/vendure/blob/bdf2329b9bc929b051cfb6d4cfc68bfd9c9537b4/packages/core/src/entity/channel/channel.entity.ts#L97-L105 It is just not currently used in the actual business logic. This means we can add support for this without requiring...

The way it will work in a future version will be like this: ``` global -> channel -> variant ``` So the `trackInventory` can be set at those 3 levels....

Yes, variants are channel aware. So in future, once the channel-level `trackInventory` setting is actually being used, then yes. Currently that is not the case.

Hi @sonntag-philipp! Apologies for the slow response to this one. And wow, this is an epic effort you have put in here! In principle I think it does make sense...

Thanks @sonntag-philipp & @taxilian So the main responsibility is indeed that bugs get fixed and (especially) any security issues are swiftly dealt with. In terms of features, in my experience...