Michael Bromley

Results 750 comments of Michael Bromley

Just throwing some thoughts down here: - This issue is a result of the fact that `Administrator` and `User` entities are **not** channel-aware, that is, they are not associated with...

@mohddotio this is something we intend to revisit for the next major version (v3), but I can't give a time estimate on this.

I'm closing this in favour of #3095 there are now a couple of people actively working on this.

Hi! Yes this is something I've wanted to do for a while. As I recall, I attempted it once but abandoned it because we have a _lot_ of e2e tests...

@Ankur-Kumar-4 sure. Let me know if you need any guidance with this.

Hi, In order to know whether this is a bug in Vendure, or just a misconfiguration on your end, we'll need to see a minimal reproduction of the issue. At...

Partly duplicated by - #3944 This issue should just cover the duplicated countries aspect, and the other issue (sort order) will be handled separately

I just checked the [contributing guide](https://github.com/typeorm/typeorm/blob/master/CONTRIBUTING.md#-submitting-a-pull-request-pr) and I couldn't clearly see an instruction on the PR name convention in particular. There is a detailed section on commit message format, but...

Hi, This looks fine - can you just give me an example use case for how you intend to use field-level interceptors so I can understand it better?

I'm hesitant to merge this due to the warning in the NestJS docs: https://docs.nestjs.com/graphql/other-features#execute-enhancers-at-the-field-resolver-level I'm concerned about any possible performance issues that might be introduced here. From my understanding, any...