Michael Bromley

Results 750 comments of Michael Bromley

The original issue is not even reproducible. I suspect this PR is AI generated because it does not make sense. And also causes all e2e test runs to fail. If...

Hi @splieseis I cannot reproduce this. Here's what I did: 1. Created a new Vendure project via `npx @vendure/create@latest my-shop` (v3.5.1) 2. Ran `npx vite` 3. Inspected the resulting gql.tada...

Hi! Thanks for this contribution. I'll need to find some time to properly review & test this - unfortunately it's unlikely in the next week due to workload.

Thanks for the nudge :) This is an amazing PR - great work on all the supporting parts for testing 👏 OK so it's now May 2025 and we have...

Hi, Since you made this PR, I added some extra logic to limit the max items per page that will be fetched. Do you want to bring this PR up...

Hi, Let's keep the per-page user setting table-specific I think.

Please can you explain to me what this is fixing. Please do not use any AI assistant when answering.

I 100% agree with you that we should support getting IDs everywhere without loading the relations. Are the tests failing for you locally? (relates to #3127)

Hi @mohamed7-dev thanks for this contribution! Would you be able to sign the CLA as outlined in https://github.com/vendure-ecommerce/vendure/pull/4008#issuecomment-3590688411 ?