Michael Bromley comments

Results 750 comments of


                                            Michael Bromley

test: Expand node version matrix to node16, node18, and node20

Excellent - do you have any idea about the failing sqlite tests?

test: Expand node version matrix to node16, node18, and node20

Excellent work, very well done!

Error creating the channel :- null value in column "defaultCurrencyCode" of relation "channel" violates not-null constraint

Hi, I cannot recreate this issue in the latest version. Can you provide exact steps to reproduce from a clean `@vendure/create` install? https://github.com/vendure-ecommerce/vendure/assets/6275952/b1d20e43-39c8-489d-be1f-528959fec347

Fix broken product image URLs in order confirmation email

Hi, thanks for reporting the issue _and_ providing a fix! I think that we can fix this without having to touch the core service & resolver. I'd rather see a...

Custom bulk action override buggy

Please provide a minimal reproduction repo

fix angular dependencies conflicts

Hi! Thanks for the contribution! Unfortunately another change I just merged means this has some conflicts to resolve. Probably the needs to have the other changed merged and then run...

Document RequestContext creation more explicitly

Thanks - all good suggestions. Are you interested in submitting a PR for these changes?

Library outdated

No, it is still maintained - I use it in several projects, some of which are on Angular v17. Which version are you having trouble with?

Library outdated

ok. please provide all relevant details of any errors you get with v18. I've not tested it yet.

Library outdated

@godenji thanks for the info. So right now you just need to entire `NgxPaginationModule` to your imports array right? I am using this package successfully with standalone components in this...