Matt Luongo
Matt Luongo
Yep! I was using `0x85eee30c52b0b379b046fb0f85f4f3dc3009afec`, the KEEP token address. Note this was on `main` prior to the merge of #1993
The `payable` / fallback idea is definitely it @hyphenized. The right behavior here is to show that the tx has failed though, even if it's not accepted into the mempool......
One of the considerations here is malicious ERC-20 contracts. For that reason, new ERC-20 rewards contracts should only be enabled per `Swap` by the admin
Another issue is snapshotting the LP tokens when balance is added. A couple approaches here. Say a new token, `AwesomeReward`, is launched. The pool earns 10M of it over 6...
> Other ideas might include using it to buy LP tokens, but that means LP tokens in a Swap can't act as de-facto stablecoins across the Swap's basket of assets...
We're doing this with a few new tokens (tBTCv2, others) and should have an audited base contract if you guys want it
@daramir thank you so much for this! We're giving it a look :smile:
@nkuba thoughts on this?
On reflection, I think this has some potentially adverse effects on group sizes at launch- if we want a robust beacon we need high value at stake. Any thoughts on...
@cryptojane55 this is another strong blog post candidate