extension
extension copied to clipboard
Sending ETH doesn't work
Sending ETH often returns to the asset page rather than the sign page. This behavior appears to depend on the recipient address... making me suspect #1900
Would you mind pasting an address here that you've seen send
fail for?
Yep! I was using 0x85eee30c52b0b379b046fb0f85f4f3dc3009afec
, the KEEP token address. Note this was on main
prior to the merge of #1993
No luck on a quick fix but one thing that is happening is we're getting {code: -32000, message: "execution reverted"}
back from alchemy when calling eth_estimateGas
with the tx
Could this be related to contracts that have their receive function set to revert transactions or lack a receive function? Sending ETH to BNB 0xB8c77482e45F1F44dE1745F52C74426C631bDD52
works 🤔
Yes - I do think that could be the case here.
My Go is a bit rusty - but here's what I think is going on:
When GETH tries to estimate gas - it simulates the transaction - and eventually returns an error if the all attempts at executing the transaction fail.
The payable
/ fallback idea is definitely it @hyphenized. The right behavior here is to show that the tx has failed though, even if it's not accepted into the mempool... particularly if I signed it first.
Can we check if the contract has a receive function and otherwise send users to the contract interaction screen?
Gas estimation reverts deserve their own admonition for the user, fwiw.
Do you see a snackbar indicating the tx failed?