Matt Luongo

Results 201 comments of Matt Luongo

@mr-michael calling your attention here: merging this PR means we'll pick up all / nearly all token balances at the risk of including scam tokens, though they'll have clear and...

@Shadowfiend @greg-nagy I opened https://github.com/tallycash/extension/issues/1893 to continue the asset trust discussion and unify the two approaches.

We don't rely soley on `alchemy_getAssetTransfers` now thankfully :) See #309 We do, however, still rely on `alchemy_getTokenBalances` in its absence. I don't know whether that has support on Kovan.

The plan is to fall back to manual balance checking per-token. It is indeed to a heavy client lift.

> Implementing getERC20TokenBalance (singular!) We have this already ☺️

Hmm, I thought we had resolved this cc @0xDaedalus

![Screenshot from 2022-08-17 17-07-13](https://user-images.githubusercontent.com/427505/185243353-e3878e08-cabb-40b1-9c00-d8627423e44f.png) The data looks right, but the page feels really crowded... not sure if that's the design. The NFT section not scrolling with the page makes it...

Here's what happens when I add `vitalik.eth` to the above ![Screenshot from 2022-08-17 17-12-51](https://user-images.githubusercontent.com/427505/185244140-a0744bc5-7de7-4d24-a099-d31532581a3e.png)

> Isn't it expected? Vitalik.eth account is in the collapsed part (if you are asking where it is), you can toggle it with "view all". It is also very large...