Mark Hansen

It's a little confusing to label it a connection if there is no e.g. TCP connection (I assumed there was a connection). I think disconnecting on .nrepl-port deletion would be...

Heh - I know next to nothing about the nrepl protocol, but assuming that it's TCP, you could potentially keep the connection open at the end. If it's HTTP, there's...

I think you're right that this is a dupe of #401 from the perspective of me wanting to embed an HTML flamegraph in a blogpost, or email it to partners...

Perhaps we could solve this by outputting folded stacks format, then using FlameGraph toolkit's profile diffing: #658

That's right. I'm not aware of any way to represent files consistently, my `(filename)` thing was just an extension for debugging. If we did implement folded stack importing, I'd probably...

Todo: I should add a test case for same stacks different labels and make sure they're aggregated together. I suspect that's not working right now, that instead it'll output duplicate...

Particularly I'd love some feedback about if there's a different function or something I should use to print the name of the stack. For example, I'd expect `-filefunctions` to show...

Some prior art: @felixge's https://github.com/felixge/pprofutils#folded can generate "Folded Stacks" format from pprof for feeding into FlameGraph toolkit.

Looks like there's options for an HTML-based tooltip in the latest d3-flamegraph: https://github.com/spiermar/d3-flame-graph#tooltip

The filename isn't passed as JSON to the FlameGraph yet, we'll want to add it to the `{{.FlameGraph}}` template variable to access it in the client.