Mark Hansen

Results 129 comments of Mark Hansen

Can't just pass `node.Info.File` to `{{.FlameGraph}}` as `.File` doesn't seem to be filled in yet, it seems empty in my test profiles.

Thanks Alexey, `-filefunctions` works pretty well! Works on the synthetic tag filenames too. ![image](https://user-images.githubusercontent.com/105529/137550563-987b9c0e-16a1-459f-ba53-c400e6609981.png)

I'm still wondering if we could put the filename in the tooltip by default, but I could go either way on it (this at least solves my immediate problem of...

I don't think we should flip the defaults. I'm just wondering about maybe sending the filename and the function name down in the JSON, and making a richer tooltip that...

The picture in my mind is something like what Firefox Profiler does: a baby step towards a richer tooltip that shows the filename (and doesn't mean the flamegraph has to...

Thank you, this is just the patch I need, to weight the samples by time taken rather than uniformly by `1`.

This isn't blocking me, or urgent or anything, in fact I wrote a [`stackcollapse.py` for Android Simpleperf](https://android.googlesource.com/platform/system/extras/+/master/simpleperf/doc/scripts_reference.md#stackcollapse_py) to work around this issue and #165.

My suggestion: change `\S*` to `[^)]*`, i.e. instead of matching all non-whitespace, match all non-closing-brackets.

> Current state of the art for profiling (what technologies, outside of pprof, are used, across languages, etc.) I think I can help with this. I've just researched the ecosystem...

FYI, I've now made a website for Profilerpedia (it's not just a Google Sheet any more): https://profilerpedia.markhansen.co.nz/, and the site renders directed graphs of profilers, their data formats, the transitive...