Mark Hansen
Mark Hansen
I think we should start by specifying the instruction set is aarch64 for `group.dex2oat` here: https://github.com/compiler-explorer/compiler-explorer/blob/fee185bf3dfbd2f44d7c651b9a0cdd4832befd0b/etc/config/android-java.amazon.properties#L71C1-L71C14 or here: https://github.com/compiler-explorer/compiler-explorer/blob/fee185bf3dfbd2f44d7c651b9a0cdd4832befd0b/etc/config/android-java.defaults.properties#L17 (not sure which one, maybe both?) We should add a line:...
Alright, I've made a PR for fixing issue #1. For issue #2, incorrectly trying to load the first word on the line (the address), instead of the second word (the...
https://github.com/compiler-explorer/compiler-explorer/blob/fee185bf3dfbd2f44d7c651b9a0cdd4832befd0b/docs/AddingALanguage.md#adding-a-new-language has instructions for how to do the syntax highlighting / monaco mode: > If the language is supported by Monaco Editor (You can find the list here), you should...
Yes, looks like default disassembly is `asm` if you don't specify anything: https://github.com/compiler-explorer/compiler-explorer/blob/fee185bf3dfbd2f44d7c651b9a0cdd4832befd0b/types/languages.interfaces.ts#L122-L123 And we don't specify anything: https://github.com/compiler-explorer/compiler-explorer/blob/fee185bf3dfbd2f44d7c651b9a0cdd4832befd0b/lib/languages.ts#L92-L101C9
It might be a bit tough to specify one disassembly syntax format for all of "Android Java" when that can include aarch64 assembly and dex bytecode. Might have to split...
Thank you! > As a quick note, arm64 will be the default when dex2oat is run on any host machine, but the output instruction set can be changed with the...
Unrelated tests seem to have failed; I rebased my branch to retry the tests and now I need approval again, my approval is outdated. @scidomino can we try approving again?
Thank you Tommaso and thanks for pushing a commit to fix the test (sorry if I missed a test!) On Thu, 4 Dec 2025 at 10:43, github-merge-queue[bot] < ***@***.***> wrote:...
Thank you, this all makes sense. A bit unfortunate but very understandable that configuring the builds for these is a tricky moving target!