Max Goltzsche

Results 34 comments of Max Goltzsche

Awesome! Looks good to me.

Coming from https://github.com/GoogleContainerTools/kpt/issues/1151#issuecomment-877836890 supporting such an include comment directive sounds interesting. My use cases that could benefit from such an include functionality are as follows: * Loading a kustomization including...

+1 for healthcheck. An image provides enough information to [derive](https://github.com/opencontainers/image-spec/blob/master/conversion.md) a runnable bundle from it - with additional defaults of the runtime. I like this approach because it follows the...

@derekbit this is also ready for review.

I just rebased this PR and resolved the conflicts.

@innobead okay. Now I created the following separate PRs: * #176 for the `mountPropagation` feature (#165). * #177 to provide params as env vars to the helper Pod (backward compatible...

PR #166 allows to specify the `mountPropagation` within the helper Pod template.

To reproduce it, [start the local-path-provisioner binary](https://github.com/rancher/local-path-provisioner#debug-1) and try terminating it using Ctrl+c - it won't stop but logs `stop watching config file` and keeps hanging [here](https://github.com/rancher/local-path-provisioner/blob/v0.0.21/main.go#L237). It seems to...

I updated the storage library dependency with #237 but it doesn't solve the termination issue unfortunately.