local-path-provisioner Fix manager termination

The manager does not terminate properly but keeps hanging until it gets killed.

Within the cluster this makes Deployment updates take more time and during local development one cannot simply terminate the manager using ctrl+c but must kill it explicitly.

Mar 06 '21 21:03 mgoltzsche

The manager does not terminate properly but keeps hanging until it gets killed.

The commit LGTM, but I'd like to fix the root cause instead. Do you know what cause the improper termination or reproduce steps?

Mar 21 '22 16:03 derekbit

To reproduce it, start the local-path-provisioner binary and try terminating it using Ctrl+c - it won't stop but logs stop watching config file and keeps hanging here. It seems to be an issue with sig-storage-lib-external-provisioner. Updating that dependency will probably solve this issue.

Mar 21 '22 23:03 mgoltzsche

I updated the storage library dependency with #237 but it doesn't solve the termination issue unfortunately.

Mar 22 '22 00:03 mgoltzsche

@mgoltzsche Thanks for your quick update. We will investigate the root cause of the hang of termination. https://github.com/mgoltzsche/local-path-provisioner/commit/f608165f75168ba41d6667f88dba2f0f40b1d14d can be a workaround.

Mar 22 '22 01:03 derekbit