local-path-provisioner icon indicating copy to clipboard operation
local-path-provisioner copied to clipboard

Published 20 hours ago • verified publisher icon rancher

Enhance helper Pod interface and configuration.

Open mgoltzsche opened this issue 4 years ago • 7 comments
trafficstars

  • Make the helper Pod receive only environment variables instead of args (this changes the interface in a non-backward compatible way but is simpler to use and potentially provides more backward compatibility in the future; #175).
  • Adds the manager options --pvc-annotation[-required] to pass through annotations from the PVC to the PV and to the helper Pod (#164).
  • Merge the helper Pod's data VolumeMount with the one provided with the template to be able to specify mountPropagation within the template (#165).
  • Rename helperPod.yaml to helper-pod.yaml (more convenient and if we break sth we can break this as well).
  • Expose --helper-pod-timeout option (#178).
  • Provide a basic usage example of the new features (examples/cache).
  • Support forceful termination of the manager binary (2xctrl+c - since this is annoying during development otherwise; #179).

Closes #164. Closes #165. Closes #175. Closes #178. Relates to #179. Relates to #127.

mgoltzsche avatar Dec 30 '20 00:12 mgoltzsche

@yasker please have a look

mgoltzsche avatar Jan 20 '21 00:01 mgoltzsche

I just rebased this PR and resolved the conflicts.

mgoltzsche avatar Feb 21 '21 23:02 mgoltzsche

Thanks for the contribution.

It looks you want to solve several issues or enhancements, so I would suggest to seperate this PR first, so we can focus on each problem you are resolving and it will be better for review.

innobead avatar Mar 02 '21 17:03 innobead

@innobead okay. Now I created the following separate PRs:

  • #176 for the mountPropagation feature (#165).
  • #177 to provide params as env vars to the helper Pod (backward compatible this time) (#175).
  • #180 to forcefully terminate the manager on 2xCtrl+c (#179).

Once #176 and #177 are merged I'll rebase and refine this PR or create another PR for #164 and eventually add the example from this PR to it (using more compact setup/teardown scripts).

mgoltzsche avatar Mar 06 '21 18:03 mgoltzsche

In regards to https://github.com/rancher/local-path-provisioner/pull/177 having been merged. I'm getting the following err:

image

In the local-path helper Pod. I deployed from https://raw.githubusercontent.com/rancher/local-path-provisioner/master/deploy/local-path-storage.yaml as the ReadMe describes - and I did so today.

Sure enough I haven't provided this VOL_DIR parameter anywhere. Where am I to do so? I can't seem to find it described anywhere.

Thank you very much.

LarsBingBong avatar Mar 21 '22 14:03 LarsBingBong

In regards to #177 having been merged. I'm getting the following err:

image

In the local-path helper Pod. I deployed from https://raw.githubusercontent.com/rancher/local-path-provisioner/master/deploy/local-path-storage.yaml as the ReadMe describes - and I did so today.

Sure enough I haven't provided this VOL_DIR parameter anywhere. Where am I to do so? I can't seem to find it described anywhere.

Thank you very much.

Thanks for your finding.

The reason is that the image in master branch's deploy/local-path-storage.yaml is rancher/local-path-provisioner:v0.0.21 rather than rancher/local-path-provisioner:master-head. The image and deploy/local-path-storage.yaml are mismatched. We will fix it later.

You can please use v0.0.21 deploy manifest. https://github.com/rancher/local-path-provisioner/tree/v0.0.21

derekbit avatar Mar 21 '22 16:03 derekbit

Yeah! That made it work! Thank you very much @derekbit

LarsBingBong avatar Mar 21 '22 17:03 LarsBingBong