Martin Geisler

Results 839 comments of Martin Geisler
trafficstars

Cc @badboy, a small note from my import review.

> I guess several other things need fixing for the new CI check to pass ... what do you think about if it should be done or not? I would...

Let's get this merged so I can make a new shiny release!

Hi @phy1729, Thanks for the PR and happy new year! > Currently `UnicodeBreakProperties.find_words("foo \nbar")` results in two Words where the first has `word: "foo \n", whitespace: ""`. I think it...

Looking at this some more, I think the output between the `AsciiSpace` and `UnicodeBreakProperties` enum variants ought to be aligned for ASCII input. This is not at all the case...

Can I ask what your use-case is for constructing words yourself? Also, have you tried the [Custom](https://docs.rs/textwrap/latest/textwrap/enum.WordSeparator.html#variant.Custom) variant? I recently realized that the constructor for `Word` is very limiting since...

As noted in https://github.com/parkerbxyz/suggest-changes/issues/37, the action creates a new review every time the PR is modified. So if the formatting errors are not resolved right away, a new comment is...

Oh no, there is another problem: the suggestions are attributed to the github-actions bot! This makes the CLA fail: ![image](https://github.com/user-attachments/assets/a7597113-7260-415f-ac76-87e40fc86d15) I think this would be the same, even if comments...

> This has been fixed in the latest release. Thanks @parkerbxyz, that sounds great! I will need to change the email address used for the suggestions (for the CLA check,...

@djmitche, we have documentation for setting up and registering a bot account here: go/github-docs/robots. I will probably go through this process to get a custom `GITHUB_TOKEN` we can use in...