Martin Geisler
Martin Geisler
Hi @miroim, nice to meet you! Thanks for looking into this. I agree we should generate binaries as part of the release — could you look into how people normally...
> To make sure everything works as expected, I'll first conduct tests in the forked repository before integrating any changes into the main project. That's the best way for this...
> Maybe related with upstream `mdbook`? [rust-lang/mdBook#2029](https://github.com/rust-lang/mdBook/pull/2029) Yes, partially: @jooyunghan also works in Android and made the PR to simplify our translation infrastructure. Here, I was thinking of making a...
Hey @sakex, I assigned this to you since this is basically what you're doing in #84. So you should update the PR to say "Fixes #13" so it will close...
Note that I've made implementing this issue a bit more complicated with https://github.com/google/comprehensive-rust/pull/1243: you'll need to use Git library to update the `src/` folder to the right version. On the...
The GitHub action in #48 could call into this script and so we avoid putting too much logic into the action (GitHub actions are nice in the context of GitHub,...
Hi @jonodeno, thanks for looking at this and sorry for the late reply! At the moment, we use [`build.sh`](https://github.com/google/comprehensive-rust/blob/main/.github/workflows/build.sh) in Comprehensive Rust to render a single language. So this script...
This is an extension of #63.
@dyoo, would you also be interested in this one?
> I'm guessing we want to define a list of lang lines to ignore somewhere, perhaps another configuration option in `book.toml` from the proposal in [#63 (comment)](https://github.com/google/mdbook-i18n-helpers/issues/63#issuecomment-1712518291) Yeah, precisely!