Martin Geisler

Results 881 comments of Martin Geisler

@kdarkhan, the problem here is about how we lose a `' '` when the Markdown AST is a mix of `Text` and `Html` nodes. I believe #125 is related: it's...

I think so too, let's close it!

> @mgeisler working on this now. How do we want the granularity to be configured? Should it be a command-line flag? Hmm, good question! I guess there are two options:...

> Questions: > > I'm assuming we'll be looking at HTML comments? Yes, precisely! They are our universal back-channel :slightly_smiling_face: > Do you already have some expectations on what the...

Your #69 looks great! I wanted to copy a comment from there to here since I think it can be useful for future PRs. Basically, we can take inspiration from...

> Overall next plan sketch: The changes in your plan look great to me! However, may I suggest a small detour: could we add a command line option to automatically...

> I need to revise it since it's being applied unconditionally here instead of as a command line option. Do you have suggestions on what that command line option should...

> So I think I may need a little more guidance here since I'm unfamiliar with the usage of mdbook-i18n-normalize; is it meaningful to have the RenderContext available when using...

> Still in progress and being cleaned up, but hopefully I'll get this ready for review shortly. I Just wanted to give you a heads up @mgeisler and to let...