Martin Geisler

Results 839 comments of Martin Geisler
trafficstars

> Btw, having run just my own tool (which calls `extract_messages()`) a number of times, closing down my editor and my terminal, I get a number of zoombie processes that...

Hi @memark, let me unassign this for now — we can assign it back to you or someone else later when activity picks up.

Hi @renepanke, sorry about the confusion — the crate has not been published yet and the README was updated too soon. Right now, you'll have to clone this repository and...

This is about adding support for the [translation context](https://www.gnu.org/software/gettext/manual/html_node/Contexts.html).

Note that this can be worked on in parallel to #57 and #65.

> When running the fuzz tests locally for longer time, I was able to trigger a panic which is caused by the parser of `pulldown-cmark`. I checked the version from...

Thanks @HidenoriKobayashi! I think there might be two problems here. First, we have this test, which demonstrates that we chop up the text when we encounter a HTML tag (including...

Further investigation shows that `extract_events(" BAZ", state)` give a `Text(Borrowed("BAZ"))` back! It should really give `" BAZ"` back so this seems to be where the space is lost.

This is actually fair: Markdown does not distinguish between a line of text starting with `" foo"` vs `"foo"`. So when we extract the events, we lose the leading whitespace....

So I think these two tests should work: ```diff diff --git a/i18n-helpers/src/bin/mdbook-gettext.rs b/i18n-helpers/src/bin/mdbook-gettext.rs index b686be4..291bb2c 100644 --- a/i18n-helpers/src/bin/mdbook-gettext.rs +++ b/i18n-helpers/src/bin/mdbook-gettext.rs @@ -233,6 +233,15 @@ mod tests { ); } +...