Ed Merks

@deepika-u Could you please squash this to a single commit?

Wouldn't it be better for there to be actual tests that run with every build?

@HeikoKlare Do you know who else might be good to review this?

@sratz It is fixing a bug and I trust in your good judgement, so I will defer the decision to you with a +1 from me (the PMC).

Just an FYI, note that the only place this event is currently handled is here: https://github.com/eclipse-platform/eclipse.platform.ui/blob/d93628bf06e59a63852a7d51bbd486ff16adb760/bundles/org.eclipse.ui.workbench/Eclipse%20UI/org/eclipse/ui/internal/WorkbenchWindow.java#L939-L953 Clearly we will not want to suggest to the user to restart Eclipse when...

The documentation of IPropertySheetPage says: > Interface for a property sheet page that appears in a property sheet view. So given you are using it in another context for another...

It's generally easiest to use the automated Oomph setup: https://github.com/eclipse-platform/.github/blob/main/CONTRIBUTING.md#creating-an-eclipse-development-environment It clones a lot more repos than you need, but it's less error prone than try to set up a...

For EMF-based editors, the properties view is a principle focal point when editing a model. Here is how things used to look:  This is how it looks now: ...

Did you try unzipping this to be sure you are trying the version that for sure has the fix? https://download.eclipse.org/eclipse/downloads/drops4/I20240818-1800/download.php?dropFile=eclipse-SDK-I20240818-1800-win32-x86_64.zip

We can’t just delete it can we? It’s API.