Ed Merks

Results 491 comments of Ed Merks

I’d expect to see IFile or IPath to be compared which know whether to do case-sensitive comparisons.

I think you should test it. I think memberPath.equals(newFilePath) will return true for two paths with different cases on a case-insensitive file system. I think you if want to check...

Yes, every time I see people wanting to replace the old URL constructor I need to warn them that it can and generally does cause problems because of URI being...

Neither no theme, nor the choice of theme has an impact. I tried clicking around in case it was just not visibly painted but actually there, but it really seems...

My primary display is also 125% The secondary is 225%.

@iloveeclipse Sorry for the reviewer bounce. I have a feeling this is not correct. Looking at the logic here, the default depends on a bunch of things such as the...

> @merks I do not get what is different in your review request? Can you explain? I **accidentally** removed him and then added him back.

@vogella My concern is that if the preference is set, then the logic at line 2357 will find a non-blank value and will not longer consider the explicit file.encoding system...

I had this with the git staging view logging errors about the beginTask thing so every time I double clicked, the error log view would show. Super annoying!