Stephen Lewis (Burrows)

icon company Google icon location Seattle, WA

Results 504 comments of Stephen Lewis (Burrows)

google_container_node_pool: for the network_config reference, call out cluster setting override

Marking this as a bug since it sounds like the behavior may be different than what users would expect from GKE. I'm not sure whether this will involve just fixing...

Add observability config to AlloyDB instance

reassigning this review since I'll be OOO.

Add support for generating plural datasources

Attn @c2thorn as well.

Use subnets with `privateIpGoogleAccess: true` in tests, as is required when u…

@slevenick FYI - would you have any concern about us moving forward with this PR?

promote gke sandbox to ga

> I didn't find a nice way in the beta provider to make either `sandbox_type` or `type` required, as well as ensuring that only one is set. I tried using...

promote gke sandbox to ga

most likely.

promote gke sandbox to ga

sorry for the confusion - it's a continuation of the previous message. it's most likely okay to not have client-side constraints in that case.

promote gke sandbox to ga

Manual GA test run (you won't have access to this): https://hashicorp.teamcity.com/buildConfiguration/TerraformProviders_GoogleCloud_GOOGLE_MMUPSTREAMTESTS_GOOGLE_PACKAGE_CONTAINER/553472

feat: support for nested write-only arguments + write-only arguments for `google_monitoring_notification_channel`

@modular-magician reassign-reviewer @melinath

feat: support for nested write-only arguments + write-only arguments for `google_monitoring_notification_channel`

marking ready for review so it'll show up in my queue.