Add observability config to AlloyDB instance

[dolphin1999]

Description: Add support to enable observability config on an AlloyDB instance.

This is for beta and GA terraform support.

Issue:

• b/340394897

Release Note Template for Downstream PRs (will be copied)

alloydb: Added `observability_config` field to `google_alloydb_instance` resource

[github-actions[bot]]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[github-actions[bot]]

@melinath This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 42 insertions(+)) google-beta provider: Diff ( 3 files changed, 355 insertions(+)) terraform-google-conversion: Diff ( 1 file changed, 106 insertions(+))

[modular-magician]

Tests analytics

Total tests: 68 Passed tests: 25 Skipped tests: 4 Affected tests: 39

Click here to see the affected service packages

• alloydb

Action taken

Found 39 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAlloydbBackup_alloydbBackupBasicTestExample|TestAccAlloydbBackup_createBackupWithMandatoryFields|TestAccAlloydbBackup_update|TestAccAlloydbBackup_usingCMEK|TestAccAlloydbCluster_alloydbSecondaryClusterBasicTestExample|TestAccAlloydbCluster_restore|TestAccAlloydbCluster_secondaryClusterPromote|TestAccAlloydbCluster_secondaryClusterPromoteAndAddAndDeleteAutomatedBackupPolicyAndInitialUser|TestAccAlloydbCluster_secondaryClusterPromoteAndAddContinuousBackupConfig|TestAccAlloydbCluster_secondaryClusterPromoteAndDeleteOriginalPrimary|TestAccAlloydbCluster_secondaryClusterPromoteAndDeleteTimeBasedRetentionPolicy|TestAccAlloydbCluster_secondaryClusterPromoteAndSimultaneousUpdate|TestAccAlloydbCluster_secondaryClusterPromoteAndUpdate|TestAccAlloydbCluster_secondaryClusterPromoteWithNetworkConfigAndAllocatedIPRange|TestAccAlloydbCluster_secondaryClusterUpdate|TestAccAlloydbCluster_secondaryClusterUsingCMEK|TestAccAlloydbCluster_secondaryClusterWithNetworkConfig|TestAccAlloydbCluster_secondaryClusterWithNetworkConfigAndAllocatedIPRange|TestAccAlloydbCluster_secondaryInstanceWithNetworkConfigAndAllocatedIPRange|TestAccAlloydbInstance_alloydbInstanceBasicTestExample|TestAccAlloydbInstance_alloydbSecondaryInstanceBasicTestExample|TestAccAlloydbInstance_clientConnectionConfig|TestAccAlloydbInstance_createInstanceWithMandatoryFields|TestAccAlloydbInstance_createInstanceWithNetworkConfigAndAllocatedIPRange|TestAccAlloydbInstance_createPrimaryAndReadPoolInstance|TestAccAlloydbInstance_networkConfig|TestAccAlloydbInstance_observabilityConfig|TestAccAlloydbInstance_secondaryInstanceMaximumFields|TestAccAlloydbInstance_secondaryInstanceUpdateDatabaseFlag|TestAccAlloydbInstance_secondaryInstanceUpdateMachineConfig|TestAccAlloydbInstance_secondaryInstanceUpdateQueryInsightConfig|TestAccAlloydbInstance_secondaryInstanceWithReadPoolInstance|TestAccAlloydbInstance_update|TestAccAlloydbInstance_updatePscInstanceConfig|TestAccAlloydbUser_alloydbUserBuiltinTestExample|TestAccAlloydbUser_alloydbUserIamTestExample|TestAccAlloydbUser_updatePassword_BuiltIn|TestAccAlloydbUser_updateRoles_BuiltIn|TestAccAlloydbUser_updateRoles_IAM

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccAlloydbBackup_alloydbBackupBasicTestExample[Error message] [Debug log] TestAccAlloydbBackup_createBackupWithMandatoryFields[Error message] [Debug log] TestAccAlloydbBackup_update[Error message] [Debug log] TestAccAlloydbBackup_usingCMEK[Error message] [Debug log] TestAccAlloydbCluster_alloydbSecondaryClusterBasicTestExample[Error message] [Debug log] TestAccAlloydbCluster_restore[Error message] [Debug log] TestAccAlloydbCluster_secondaryClusterPromote[Error message] [Debug log] TestAccAlloydbCluster_secondaryClusterPromoteAndAddAndDeleteAutomatedBackupPolicyAndInitialUser[Error message] [Debug log] TestAccAlloydbCluster_secondaryClusterPromoteAndAddContinuousBackupConfig[Error message] [Debug log] TestAccAlloydbCluster_secondaryClusterPromoteAndDeleteOriginalPrimary[Error message] [Debug log] TestAccAlloydbCluster_secondaryClusterPromoteAndDeleteTimeBasedRetentionPolicy[Error message] [Debug log] TestAccAlloydbCluster_secondaryClusterPromoteAndSimultaneousUpdate[Error message] [Debug log] TestAccAlloydbCluster_secondaryClusterPromoteAndUpdate[Error message] [Debug log] TestAccAlloydbCluster_secondaryClusterPromoteWithNetworkConfigAndAllocatedIPRange[Error message] [Debug log] TestAccAlloydbCluster_secondaryClusterUpdate[Error message] [Debug log] TestAccAlloydbCluster_secondaryClusterUsingCMEK[Error message] [Debug log] TestAccAlloydbCluster_secondaryClusterWithNetworkConfig[Error message] [Debug log] TestAccAlloydbCluster_secondaryClusterWithNetworkConfigAndAllocatedIPRange[Error message] [Debug log] TestAccAlloydbCluster_secondaryInstanceWithNetworkConfigAndAllocatedIPRange[Error message] [Debug log] TestAccAlloydbInstance_alloydbInstanceBasicTestExample[Error message] [Debug log] TestAccAlloydbInstance_alloydbSecondaryInstanceBasicTestExample[Error message] [Debug log] TestAccAlloydbInstance_clientConnectionConfig[Error message] [Debug log] TestAccAlloydbInstance_createInstanceWithMandatoryFields[Error message] [Debug log] TestAccAlloydbInstance_createInstanceWithNetworkConfigAndAllocatedIPRange[Error message] [Debug log] TestAccAlloydbInstance_createPrimaryAndReadPoolInstance[Error message] [Debug log] TestAccAlloydbInstance_networkConfig[Error message] [Debug log] TestAccAlloydbInstance_observabilityConfig[Error message] [Debug log] TestAccAlloydbInstance_secondaryInstanceMaximumFields[Error message] [Debug log] TestAccAlloydbInstance_secondaryInstanceUpdateDatabaseFlag[Error message] [Debug log] TestAccAlloydbInstance_secondaryInstanceUpdateMachineConfig[Error message] [Debug log] TestAccAlloydbInstance_secondaryInstanceUpdateQueryInsightConfig[Error message] [Debug log] TestAccAlloydbInstance_secondaryInstanceWithReadPoolInstance[Error message] [Debug log] TestAccAlloydbInstance_update[Error message] [Debug log] TestAccAlloydbInstance_updatePscInstanceConfig[Error message] [Debug log] TestAccAlloydbUser_alloydbUserBuiltinTestExample[Error message] [Debug log] TestAccAlloydbUser_alloydbUserIamTestExample[Error message] [Debug log] TestAccAlloydbUser_updatePassword_BuiltIn[Error message] [Debug log] TestAccAlloydbUser_updateRoles_BuiltIn[Error message] [Debug log] TestAccAlloydbUser_updateRoles_IAM[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 294 insertions(+)) google-beta provider: Diff ( 2 files changed, 294 insertions(+)) terraform-google-conversion: Diff ( 1 file changed, 106 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_alloydb_instance (79 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_alloydb_instance" "primary" {
  observability_config {
    enabled                 = # value needed
    max_query_string_length = # value needed
    preserve_comments       = # value needed
    query_plans_per_minute  = # value needed
    record_application_tags = # value needed
    track_active_queries    = # value needed
    track_wait_event_types  = # value needed
    track_wait_events       = # value needed
  }
}

[modular-magician]

Tests analytics

Total tests: 67 Passed tests: 56 Skipped tests: 4 Affected tests: 7

Click here to see the affected service packages

• alloydb

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAlloydbInstance_clientConnectionConfig|TestAccAlloydbInstance_networkConfig|TestAccAlloydbInstance_secondaryInstanceUpdateDatabaseFlag|TestAccAlloydbInstance_secondaryInstanceUpdateMachineConfig|TestAccAlloydbInstance_secondaryInstanceUpdateQueryInsightConfig|TestAccAlloydbInstance_update|TestAccAlloydbInstance_updatePscInstanceConfig

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$ TestAccAlloydbInstance_clientConnectionConfig[Debug log] TestAccAlloydbInstance_networkConfig[Debug log] TestAccAlloydbInstance_secondaryInstanceUpdateDatabaseFlag[Debug log] TestAccAlloydbInstance_secondaryInstanceUpdateMachineConfig[Debug log] TestAccAlloydbInstance_secondaryInstanceUpdateQueryInsightConfig[Debug log] TestAccAlloydbInstance_update[Debug log] TestAccAlloydbInstance_updatePscInstanceConfig[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$ View the build log or the debug log for each test

[melinath]

reassigning this review since I'll be OOO.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 294 insertions(+)) google-beta provider: Diff ( 2 files changed, 294 insertions(+)) terraform-google-conversion: Diff ( 1 file changed, 106 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_alloydb_instance (79 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_alloydb_instance" "primary" {
  observability_config {
    enabled                 = # value needed
    max_query_string_length = # value needed
    preserve_comments       = # value needed
    query_plans_per_minute  = # value needed
    record_application_tags = # value needed
    track_active_queries    = # value needed
    track_wait_event_types  = # value needed
    track_wait_events       = # value needed
  }
}

[modular-magician]

Tests analytics

Total tests: 67 Passed tests: 63 Skipped tests: 4 Affected tests: 0

Click here to see the affected service packages

• alloydb

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

[dolphin1999]

Could you add some test to cover this added field?

Added the tests back but as the test only will pass after a project level flag is enabled.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 42 insertions(+)) google-beta provider: Diff ( 3 files changed, 356 insertions(+)) terraform-google-conversion: Diff ( 1 file changed, 106 insertions(+))

[modular-magician]

Tests analytics

Total tests: 68 Passed tests: 63 Skipped tests: 4 Affected tests: 1

Click here to see the affected service packages

• alloydb

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccAlloydbInstance_observabilityConfig

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccAlloydbInstance_observabilityConfig[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

[hao-nan-li]

Turned Gemini in DB on, need ~24-48 hours. Will re-run next Monday and see.

[hao-nan-li]

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 42 insertions(+)) google-beta provider: Diff ( 3 files changed, 356 insertions(+)) terraform-google-conversion: Diff ( 1 file changed, 106 insertions(+))

[modular-magician]

Tests analytics

Total tests: 68 Passed tests: 63 Skipped tests: 4 Affected tests: 1

Click here to see the affected service packages

• alloydb

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccAlloydbInstance_observabilityConfig

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccAlloydbInstance_observabilityConfig[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

[hao-nan-li]

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 42 insertions(+)) google-beta provider: Diff ( 3 files changed, 356 insertions(+)) terraform-google-conversion: Diff ( 1 file changed, 106 insertions(+))

[modular-magician]

Tests analytics

Total tests: 68 Passed tests: 63 Skipped tests: 4 Affected tests: 1

Click here to see the affected service packages

• alloydb

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccAlloydbInstance_observabilityConfig

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccAlloydbInstance_observabilityConfig[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

[github-actions[bot]]

@hao-nan-li @melinath This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions[bot]]

@GoogleCloudPlatform/terraform-team @hao-nan-li @melinath This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

[hao-nan-li]

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 42 insertions(+)) google-beta provider: Diff ( 3 files changed, 356 insertions(+)) terraform-google-conversion: Diff ( 1 file changed, 106 insertions(+))

[modular-magician]

Tests analytics

Total tests: 68 Passed tests: 63 Skipped tests: 4 Affected tests: 1

Click here to see the affected service packages

• alloydb

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccAlloydbInstance_observabilityConfig

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccAlloydbInstance_observabilityConfig[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test