Stephen Lewis (Burrows)
Stephen Lewis (Burrows)
@hoskeri could you confirm the expected API behavior?
apologies for the delayed review. I've been working through a backlog. I should be able to take a look tomorrow. In general this does look like a good change; I...
yeah force pushes that leave the history intact are fine.
> Sure - I can add it. Do you want it in an existing test or a standalone new test case? > > only caveat is that, since we already...
sure, seems fine
Apologies for the delayed review - reassigning since I'll be OOO tomorrow.
@BBBmau looks like this fixes a 100% test failure - are you still working on it?
after discussion, we've decided to move forward with the allowlist in place. Marking for review
@bskaplan could you add the resource name to the release notes? Something like: `added x fields to the Y resource (ga)`
Running tests in GA to be safe: - https://hashicorp.teamcity.com/buildConfiguration/TerraformProviders_GoogleCloud_GOOGLE_MMUPSTREAMTESTS_GOOGLE_PACKAGE_CLOUDRUN/222906 - https://hashicorp.teamcity.com/buildConfiguration/TerraformProviders_GoogleCloud_GOOGLE_MMUPSTREAMTESTS_GOOGLE_PACKAGE_CLOUDRUNV2/222907