Stephen Lewis (Burrows)

Results 505 comments of Stephen Lewis (Burrows)

Running tests in GA again. Cloudrun: https://hashicorp.teamcity.com/buildConfiguration/TerraformProviders_GoogleCloud_GOOGLE_MMUPSTREAMTESTS_GOOGLE_PACKAGE_CLOUDRUN/223359?hideTestsFromDependencies=false&hideProblemsFromDependencies=false&expandBuildChangesSection=true Cloudrunv2: https://hashicorp.teamcity.com/buildConfiguration/TerraformProviders_GoogleCloud_GOOGLE_MMUPSTREAMTESTS_GOOGLE_PACKAGE_CLOUDRUNV2/223360?hideTestsFromDependencies=false&hideProblemsFromDependencies=false

GA tests: CloudRun: https://hashicorp.teamcity.com/buildConfiguration/TerraformProviders_GoogleCloud_GOOGLE_MMUPSTREAMTESTS_GOOGLE_PACKAGE_CLOUDRUN/226387?hideTestsFromDependencies=false&hideProblemsFromDependencies=false&expandBuildChangesSection=true CloudRunV2: https://hashicorp.teamcity.com/buildConfiguration/TerraformProviders_GoogleCloud_GOOGLE_MMUPSTREAMTESTS_GOOGLE_PACKAGE_CLOUDRUNV2/226388?hideTestsFromDependencies=false&hideProblemsFromDependencies=false

drive-by /gcbrun

@panerorenn9541 Just want to confirm this is no longer waiting for GA?

~@ScottSuarez could you do a manual run of `TestAccSpannerDatabase_mrcmek`? It's skipped in VCR~ Never mind, we should fix the bootstrapping / IAM first.

Just to clarify why I'm here: Scott had asked me to take a look because he ended up making fairly significant changes to the code when porting it to Go...

I think the automation detected a comment from a core team member even though it's from the PR author

> 1. Agree that "conflicts" is a slightly confusing name, but it can be argued that all four of `AtLeastOneOf` `RequiredWith` `ExactlyOneOf` and `Conflicts` are types of conflicts in that...

@yungdarek122 is there an open issue about this or a specific plan to update the allowed values here? Otherwise it would be preferable to leave the validation in place, since...