magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

Use subnets with `privateIpGoogleAccess: true` in tests, as is required when u…

Open Harwayne opened this issue 1 year ago • 3 comments

Use subnets with privateIpGoogleAccess: true in tests, as is required when using the now default internal_ip_only: true (as of Dataproc 2.2).

Note that this is a Test only chang.e

Release Note Template for Downstream PRs (will be copied)


Harwayne avatar Oct 04 '24 18:10 Harwayne

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

github-actions[bot] avatar Oct 04 '24 19:10 github-actions[bot]

@slevenick FYI - would you have any concern about us moving forward with this PR?

melinath avatar Oct 08 '24 22:10 melinath

@slevenick FYI - would you have any concern about us moving forward with this PR?

I would just make sure tests pass after my PR from last week changed several of them. I fixed most of the failing dataproc tests, though I think there was another server-side change that is causing some to fail on actually setting up dataproc

slevenick avatar Oct 15 '24 13:10 slevenick

@Harwayne, this PR is waiting for action from you. If no action is taken, this PR will be closed in 28 days.

Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

Image showing the re-request review button

This notification can be disabled with the disable-automatic-closure label.

github-actions[bot] avatar Oct 22 '24 09:10 github-actions[bot]

@Harwayne, this PR is waiting for action from you. If no action is taken, this PR will be closed in 14 days.

Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

Image showing the re-request review button

This notification can be disabled with the disable-automatic-closure label.

github-actions[bot] avatar Nov 05 '24 09:11 github-actions[bot]

@Harwayne, this PR is waiting for action from you. If no action is taken, this PR will be closed in 2 weekdays.

Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

Image showing the re-request review button

This notification can be disabled with the disable-automatic-closure label.

github-actions[bot] avatar Nov 15 '24 09:11 github-actions[bot]

@Harwayne, this PR is being closed due to inactivity.

github-actions[bot] avatar Nov 19 '24 09:11 github-actions[bot]