Stephen Lewis (Burrows)
Stephen Lewis (Burrows)
It looks like defaultTtl can be set to zero or omitted, and those have different meanings. Additionally, it sounds from the [API docs](https://cloud.google.com/media-cdn/docs/reference/rest/v1/projects.locations.edgeCacheServices#CacheMode) like there's a server-side default of `3600s`...
If this can be handled with encoders I believe it should be possible to fix without a breaking change.
Regarding the failed TGC tests - you'll need to account for the fact that references to service account emails are known before apply in two files: - [example_google_composer_environment.json](https://github.com/GoogleCloudPlatform/magic-modules/blob/b0450ba0e17ac08ac7e07aa3bbb6eeea51785db4/mmv1/third_party/tgc/tests/data/example_google_composer_environment.json#L9-L11) in the...
It looks like TGC already has custom logic to add the email into the API object (to get around the fact it's missing in the plan): https://github.com/GoogleCloudPlatform/terraform-google-conversion/blob/aa4f4879b9078957d64d3dc68342817020601124/tfplan2cai/converters/google/resources/services/resourcemanager/service_account.go#L104-L107 So at least...
The format for the service account is documented here: https://cloud.google.com/iam/docs/service-accounts-create#creating so it should definitely be safe to precompute as long as the universe_domain is `googleapis.com`. I'm working on figuring out...
The test failures are unrelated.
Correctness: - Is the license text being added the correct license text? - Does it have the current year Which files: Basically, any files that correspond to other files that...
@NickElliot my change request has been addressed, back to you.
FWIW to me this feels like a reasonable situation for acquire-on-create behavior. I don't think these PRs necessarily conflict & having both seems like it's probably good for users.