magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

Add Resource v1 SCC Findings Export to BQ Organization Config

Open vijaykanthm opened this issue 1 year ago • 1 comments

Related to http://b/356159589.

Bug Description: https://github.com/hashicorp/terraform-provider-google/issues/18848

Adding new template for V1 SCC Findings Exports to Big Query Organization Config https://cloud.google.com/security-command-center/docs/reference/rest/v1/organizations.bigQueryExports

Release Note Template for Downstream PRs (will be copied)

`google_scc_organization_scc_big_query_exports`

vijaykanthm avatar Aug 29 '24 18:08 vijaykanthm

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

github-actions[bot] avatar Aug 29 '24 18:08 github-actions[bot]

@NickElliot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar Sep 03 '24 09:09 github-actions[bot]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 915 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 5 files changed, 915 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 89 insertions(+))

modular-magician avatar Sep 04 '24 20:09 modular-magician

Tests analytics

Total tests: 15 Passed tests: 14 Skipped tests: 0 Affected tests: 1

Click here to see the affected service packages
  • securitycenter

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccSecurityCenterOrganizationBigQueryExportConfig_basic

Get to know how VCR tests work

modular-magician avatar Sep 04 '24 20:09 modular-magician

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$ TestAccSecurityCenterOrganizationBigQueryExportConfig_basic[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

modular-magician avatar Sep 04 '24 20:09 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 914 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 5 files changed, 914 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 89 insertions(+))

modular-magician avatar Sep 04 '24 21:09 modular-magician

Tests analytics

Total tests: 15 Passed tests: 15 Skipped tests: 0 Affected tests: 0

Click here to see the affected service packages
  • securitycenter

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

modular-magician avatar Sep 04 '24 21:09 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 914 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 5 files changed, 914 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 89 insertions(+))

modular-magician avatar Sep 09 '24 21:09 modular-magician

Tests analytics

Total tests: 15 Passed tests: 15 Skipped tests: 0 Affected tests: 0

Click here to see the affected service packages
  • securitycenter

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

modular-magician avatar Sep 09 '24 21:09 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 914 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 5 files changed, 914 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 89 insertions(+))

modular-magician avatar Sep 09 '24 22:09 modular-magician

Tests analytics

Total tests: 15 Passed tests: 15 Skipped tests: 0 Affected tests: 0

Click here to see the affected service packages
  • securitycenter

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

modular-magician avatar Sep 09 '24 22:09 modular-magician

@NickElliot my change request has been addressed, back to you.

melinath avatar Sep 11 '24 22:09 melinath

@NickElliot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar Sep 12 '24 09:09 github-actions[bot]