Stephen Lewis (Burrows)
Stephen Lewis (Burrows)
We had an issue in a DCL->MMv1 migration PR for orgpolicy_policy where the resource would "disappear" on upgrade because the expected ID format changed. We believe this would have been...
This is a generated resource: https://github.com/GoogleCloudPlatform/magic-modules/blob/main/mmv1/products/compute/ManagedSslCertificate.yaml so the docs & implementation come from the same source.
This is a breaking change, but it falls under the "fixing a bug" exception and is therefore allowed in a minor release: https://googlecloudplatform.github.io/magic-modules/breaking-changes/make-a-breaking-change/#in-minor-releases
Note from triage: The fix here would be conditional immutability as described at https://googlecloudplatform.github.io/magic-modules/best-practices/immutable-fields/
@modular-magician reassign-reviewer @ScottSuarez Hey Scott - could you take over this review?
Did a quick glance through and it seems about like I'd expect but I didn't look closely.
@modular-magician reassign-reviewer @ScottSuarez
Note from triage: This is currently in alpha
@AndrewBurian please mark this as not a draft when it is ready for review - thanks!
Note from triage: It sounds like the issue here is that google_firebase_hosting_custom_domain.required_dns_updates.desired only contains items the need to exist (but don't yet exist), which means that once they are created,...