Stephen Lewis (Burrows)

icon company Google icon location Seattle, WA

Results 505 comments of Stephen Lewis (Burrows)

Add Resource v1 SCC Findings Export to BQ Folder Config

/gcbrun

Add Resource v1 SCC Findings Export to BQ Folder Config

/gcbrun

Add Resource v1 SCC Findings Export to BQ Folder Config

Also clarified the change request on https://github.com/GoogleCloudPlatform/magic-modules/pull/11587#discussion_r1755737188

transport/http: use ipv4 explicitly for dialers if ipv6 is not supported

The conventionalcommits linter conflicts with https://github.com/googleapis/google-api-go-client/blob/main/CONTRIBUTING.md - which should I follow?

transport/http: use ipv4 explicitly for dialers if ipv6 is not supported

I'll assume conventionalcommits for now.

transport/http: use ipv4 explicitly for dialers if ipv6 is not supported

Just to clarify, are you suggesting that I should override the global `http.DefaultTransport` variable? That seems like it could have unintended side effects. This bug impacts all users of this...

transport/http: use ipv4 explicitly for dialers if ipv6 is not supported

For some discussion of how modifying the global state of DefaultTransport can be problematic, see https://github.com/hashicorp/go-cleanhttp?tab=readme-ov-file#cleanhttp

transport/http: use ipv4 explicitly for dialers if ipv6 is not supported

@noahdietz @codyoss any updates on whether you will consider this contribution? It would be great to fix this issue here instead of downstream users of the libraries!

Support serverless neg in google_compute_region_backend_service

@hao-nan-li could you look into making the changes requested in https://github.com/hashicorp/terraform-provider-google/issues/12299#issuecomment-2132987091 if appropriate?

compute: added `shared_secret_wo` and `shared_secret_wo_version` fields to `google_compute_vpn_tunnel` + changes to `write_only` implementation in generator/templating

> If this is indeed an aspect within magic-modules that is desired to get improved, I think the refactor is easier to do now than in for example 1 or...