GoogleCloudPlatform
Add a license check for new files
https://github.com/hashicorp/terraform-provider-google/issues/20127
- Check license type (using a go-licenses library)
- Check copyright year (using strings.Contains)
Tested in https://github.com/GoogleCloudPlatform/magic-modules/pull/13805.
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR hasn't generated any diffs, but I'll let you know if a future commit does.
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR hasn't generated any diffs, but I'll let you know if a future commit does.
@shuyama1 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
@GoogleCloudPlatform/terraform-team @shuyama1 This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.
Correctness:
- Is the license text being added the correct license text?
- Does it have the current year
Which files: Basically, any files that correspond to other files that currently have it. MMv1 yaml, definitely. tpgtools we can ignore for now because it's not getting new stuff added. I'm not sure if there are other files.
We should only be running this check for files modified in the current PR.
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR hasn't generated any diffs, but I'll let you know if a future commit does.
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR hasn't generated any diffs, but I'll let you know if a future commit does.
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR hasn't generated any diffs, but I'll let you know if a future commit does.
The current code is checking only the mmv1 folder for .tmpl, .go, .yaml files, and only for new files. If checking for just modified files, then many files will need a touch for the copyright year.
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR hasn't generated any diffs, but I'll let you know if a future commit does.
@shuyama1 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.
@GoogleCloudPlatform/terraform-team @shuyama1 This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.
@GoogleCloudPlatform/terraform-team @shuyama1 This PR has been waiting for review for 2 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.
@GoogleCloudPlatform/terraform-team @shuyama1 This PR has been waiting for review for 3 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.
@GoogleCloudPlatform/terraform-team @shuyama1 This PR has been waiting for review for 4 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.
@GoogleCloudPlatform/terraform-team @shuyama1 This PR has been waiting for review for 5 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR hasn't generated any diffs, but I'll let you know if a future commit does.
@shuyama1 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.
@GoogleCloudPlatform/terraform-team @shuyama1 This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.
@GoogleCloudPlatform/terraform-team @shuyama1 This PR has been waiting for review for 2 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.
Rebase is done, the pr size is still large probably it considers the testdata files.
@GoogleCloudPlatform/terraform-team @shuyama1 This PR has been waiting for review for 3 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.