ScopeLift
feat: unstoppable domains upgrade + reverse resolution
Description
Upgraded unstoppable domain package and added reverse resolution
Reverse Resolution :
You can also use our Unstoppable Domains to check lookup Functionality : blockdudes.blockchain resolved to 0x89f9798a8d8bac15a47031779cc6aa08d8059c52
Deploy request for jolly-shaw-20fe62 pending review.
Visit the deploys page to approve it
| Name | Link |
|---|---|
| Latest commit | c7ea16a67fb35daef85a33fb5841047269f947e1 |
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
@apbendi Thanks for the review
- Fixed
- The issue is same for the ENS address, but I added this functionality so it is also solved
- The issue was the casing, so I lowercased both address at the time of checking, is that ok?
thanks @amritkumarj
The issue is same for the ENS address, but I added this functionality so it is also solved
Right it broken on ENS for this PR but wasn't in prod! Seems to be working for both case now 👍
The issue was the casing, so I lowercased both address at the time of checking, is that ok?
You mean you downcase both addresses to do the compare, right? If so, sounds perfectly reasonable.
Overall PR is looking good and seems to work well! Nice job. One annoying request: instead of the merge commit of master into your branch, can you remove the merge commit and rebase the branch instead? We try to keep merges out of history.
@mds1 could you give the code another quick look over as well? From my perspective looks good, but it's touching a lot of sections you know best. Thanks!
Hey @amritkumarj, just bumping the last few open comments. The branch is also now out of date with master 🙂
@mds1 pushed the changes, please check the cns.test file, as we are using polygon mainnet for testing because rinkeby being discontinued
LGTM, thank you @amritkumarj! Do you mind resolving conflicts, then we should be good to merge once CI passes pending any comments from @apbendi. (CI will probably fail now, but should pass once the latest main is incorporated)