Matt Solomon
Matt Solomon
@odyslam what's the status of this issue? The second item is checked off but issue is opened, so I'm not certain
@odyslam got another one for you here: https://github.com/foundry-rs/foundry/issues/4601
Got another one from forge-std, full list is below. I haven't triaged these yet, i.e. there may be duplicates, etc. - https://github.com/foundry-rs/forge-std/issues/332 - https://github.com/foundry-rs/foundry/issues/4601 - https://github.com/foundry-rs/forge-std/issues/244#issuecomment-1333648770 - https://github.com/foundry-rs/foundry/issues/3731 - https://github.com/foundry-rs/foundry/issues/3754...
Hmm interesting, I don't recall anything touching this functionality recently that would have broken it. Are you certain it's the forge-std version bump that causes the issue, as opposed to...
This seems useful to me, @mattsse any objections here?
forge does [have](https://github.com/foundry-rs/forge-std/blob/5bbb2aa82d86456dbf03305c3704cbd4fa93473f/src/Vm.sol#L290-L293) `pauseGasMetering` and `resumeGasMetering` cheats which effectively give the same behavior, perhaps you could use those cheat names on the KEVM side to prevent needing an `infiniteGas` cheat...
Agreed, I do think these would be generically useful and they all seem pretty straightforward to implement, cc @mattsse. @ehildenb I think 1 or 2 examples of how usage would...
Using git bisect, I have confirmed https://github.com/foundry-rs/foundry/pull/8543 is the PR that introduced this bug. Before that PR, URLs are properly encoded when logged: `https://dashboard.tenderly.co/TENDERLY_USERNAME/TENDERLY_PROJECT/simulator/new?network=10&contractAddress=0xcA11bde05977b3631167028862bE2a173976CA11&from=0x1804c8AB1F12E6bbf3894d4083f33e07309d1f38&stateOverrides=%5B%7B"contractAddress":"0x0a7361e734cf3f0394B0FC4a45C74E7a4Ec70940","storage":%5B%7B"key":"0x0000000000000000000000000000000000000000000000000000000000000004","value":"0x0000000000000000000000000000000000000000000000000000000000000001"%7D%5D%7D,%7B"contractAddress":"0x2501c477D0A35545a387Aa4A3EEe4292A9a8B3F0","storage":%5B%7B"key":"0x0000000000000000000000000000000000000000000000000000000000000004","value":"0x0000000000000000000000000000000000000000000000000000000000000001"%7D,%7B"key":"0x0000000.....` After, you can see the improper...
Problem: - In the [base-org/contracts repo](https://github.com/base-org/contracts), in the [`approve`](https://github.com/base-org/contracts/blob/c14278a67d6eb029d3b9b505eea67d2b2ea637af/script/universal/NestedMultisigBuilder.sol#L104-L124) method in `script/universal/NestedMultisigBuilder.sol` - We always concatenate the given `_signatures` with the `prevalidatedSignatures(approvers)`, even if the given signatures include a prevalidate...
I see https://github.com/base-org/contracts/pull/95 was merged, so closing this as completed. Thank you both!