foundry icon indicating copy to clipboard operation
foundry copied to clipboard

Published 20 hours ago • verified publisher icon foundry-rs

meta(parsing): tracking issue for JSON / TOML parsing + writing

Open odyslam opened this issue 2 years ago • 6 comments

  • [ ] https://github.com/foundry-rs/foundry/issues/3731
  • [x] https://github.com/foundry-rs/foundry/issues/3754
  • [ ] https://github.com/foundry-rs/foundry/issues/4601
  • [ ] https://github.com/foundry-rs/forge-std/issues/332
  • [ ] https://github.com/foundry-rs/foundry/issues/4601
  • [ ] https://github.com/foundry-rs/forge-std/issues/244#issuecomment-1333648770
  • [ ] https://github.com/foundry-rs/foundry/issues/3731
  • [x] https://github.com/foundry-rs/foundry/issues/3754
  • [x] https://github.com/foundry-rs/foundry/issues/4630 (should be closed soon by #4631)
  • [x] https://github.com/foundry-rs/foundry/issues/4592 (closed, but @sakulstra says it still happens)
  • [ ] https://github.com/foundry-rs/forge-std/issues/372
  • [x] https://github.com/foundry-rs/foundry/issues/5369
  • [ ] https://github.com/foundry-rs/foundry/issues/5424
  • [x] https://github.com/foundry-rs/foundry/issues/5423
  • [x] https://github.com/foundry-rs/foundry/issues/5422
  • [x] Exclude other cheat inputs/outputs from traces: https://github.com/foundry-rs/foundry/pull/5431#discussion_r1267121945
  • [ ] https://github.com/foundry-rs/foundry/issues/8135
  • [ ] https://github.com/foundry-rs/foundry/issues/4844
  • [x] https://github.com/foundry-rs/foundry/issues/8326
  • [ ] https://github.com/foundry-rs/foundry/issues/5182
  • [ ] https://github.com/foundry-rs/foundry/issues/5764
  • [x] https://github.com/foundry-rs/foundry/issues/6533
  • [ ] https://github.com/foundry-rs/foundry/issues/7052
  • [ ] https://github.com/foundry-rs/foundry/issues/7232
  • [ ] https://github.com/foundry-rs/foundry/issues/8467

odyslam avatar Dec 01 '22 13:12 odyslam

@odyslam what's the status of this issue? The second item is checked off but issue is opened, so I'm not certain

mds1 avatar Mar 10 '23 00:03 mds1

@mds1 the issue with array escaping is still present for sure (just faced on latest forge std and stumbled over this issue)

sakulstra avatar Mar 16 '23 10:03 sakulstra

@odyslam got another one for you here: https://github.com/foundry-rs/foundry/issues/4601

mds1 avatar Mar 21 '23 20:03 mds1

@sakulstra can you elaborate a bit on the array escaping issue and share your code. More use-cases I have, the easier it's to solve this.

I need to prioritize some time to work on these issues

odyslam avatar Mar 21 '23 20:03 odyslam

@odyslam I refactored the code to no longer use arrays :sweat_smile:

That said, you can reproduce with this hash 3fb1ca077af827e9138b71d62f2b6f64c8a7b2b7 on https://github.com/bgd-labs/aave-helpers/tree/feat/config-snapshot-v2 by running forge test (json is written to reports folder)

It's this function: https://github.com/bgd-labs/aave-helpers/blob/3fb1ca077af827e9138b71d62f2b6f64c8a7b2b7/src/ProtocolV3TestBase.sol#L78 writing an array e.g. here: https://github.com/bgd-labs/aave-helpers/blob/3fb1ca077af827e9138b71d62f2b6f64c8a7b2b7/src/ProtocolV3TestBase.sol#L299

sakulstra avatar Mar 21 '23 20:03 sakulstra

Got another one from forge-std, full list is below. I haven't triaged these yet, i.e. there may be duplicates, etc.

  • https://github.com/foundry-rs/forge-std/issues/332
  • https://github.com/foundry-rs/foundry/issues/4601
  • https://github.com/foundry-rs/forge-std/issues/244#issuecomment-1333648770
  • https://github.com/foundry-rs/foundry/issues/3731
  • https://github.com/foundry-rs/foundry/issues/3754
  • https://github.com/foundry-rs/foundry/issues/4630 (should be closed soon by #4631)
  • https://github.com/foundry-rs/foundry/issues/4592 (closed, but @sakulstra says it still happens)
  • https://github.com/foundry-rs/forge-std/issues/372
  • https://github.com/foundry-rs/foundry/issues/5369
  • https://github.com/foundry-rs/foundry/issues/5424
  • https://github.com/foundry-rs/foundry/issues/5423
  • https://github.com/foundry-rs/foundry/issues/5422
  • Exclude other cheat inputs/outputs from traces: https://github.com/foundry-rs/foundry/pull/5431#discussion_r1267121945

mds1 avatar Mar 24 '23 13:03 mds1