Matt Solomon
Matt Solomon
Ah yea it does show the number of fuzz runs after a run already. The main motivation for opening this issue was to show a counter during the fuzz runs....
This current behavior should probably be the expected behavior, right? If you call `vm.prank(user)` followed by `address(x).delegatecall(...)`, and the delegatecall executes in the context of `user`, this enables delegatecalling from...
Ah, I think I misunderstood what you were trying to do. Let me know if this is the correct explanation of the issue: - `MyTestContract is DSTest` has a test...
Got it, makes sense. Agreed the current behavior is confusing, so I think there's two ways to improve it, let me know if you have other ideas: 1. Leave behavior...
@Mouradif You may need to update your foundry and forge-std versions, you can see it in forge-std here: https://github.com/foundry-rs/forge-std/blob/ab6de56ed94bed75866c78c62cad882e8a046348/src/Vm.sol#L1607-L1614
Reassigning to @geoknee to take this over the line. Let's also make sure there's a CI check that runs on PRs
One other upside is that some tooling requires checksummed addresses, for example if you paste an address from the registry into a solidity contract. The friction is a good point...
Yea the rest of our checks should catch typo errors (e.g. a call to a typo'd address will not return the expected data), so the main value of checksums IMO...
My preferred solution would be: - If the chain is not in the upstream repo: we do the chain ID + name + short name uniqueness checks ourselves - If...