Matthew Booth
Matthew Booth
> To me microversions can be used to detect support for a feature. In this case we'd do multi-attachable volumes if available microversion exceeds 2.73 and then we use 2.73...
> Thanks for the comments! I guess I will have to swallow it and start working on those feature gates 🙂 > > Just for the records though, I'm not...
The lint errors are wrong. In the past I've found these problems normally go away when I bump golanci-lint. However, the newest golangci-lint image we have is built against Go...
/test lint
/retest-required
IFAIR CAPI's failure domains are only used by the kubeadm provider. The kubeadm control plane provider sets the failure domain explicitly when creating a machine. If you aren't using that...
FWIW, specifically here: https://github.com/kubernetes-sigs/cluster-api/blob/31ea0af963eecf1938c9c7eae75491b0cece4e39/controlplane/kubeadm/internal/controllers/scale.go#L91-L94
Ah, so it was an upgrade thing at some point? Sounds like we should remove it? It's just a trip hazard now.
I think I will move our 'hydrated' failure domain to the InfrastructureMachineStatus instead. This is a bit of a workaround, but it was a reasonable candidate for somewhere to stash...