NO-JIRA: Bump Go to 1.24
Go 1.24 requires format strings to be string constants.
@mdbooth: This pull request explicitly references no jira issue.
In response to this:
Go 1.24 requires format strings to be string constants.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: mdbooth Once this PR has been reviewed and has the lgtm label, please assign dgoodwin for approval. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
The lint errors are wrong. In the past I've found these problems normally go away when I bump golanci-lint. However, the newest golangci-lint image we have is built against Go 1.23, so we can't use it with Go 1.24:
https://github.com/openshift/release/blob/8f06238188359fa692b5e270e3d16aafaefc7034/core-services/image-mirroring/_config.yaml#L836-L837
/test lint
/retest-required
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@mdbooth: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ci/prow/e2e-gcp-fips-serial-1of2 | ddfd8aee7bd0ccd4c9ac7651918967468996a97e | link | false | /test e2e-gcp-fips-serial-1of2 |
| ci/prow/e2e-openstack-ovn | ddfd8aee7bd0ccd4c9ac7651918967468996a97e | link | false | /test e2e-openstack-ovn |
| ci/prow/e2e-azure-ovn-etcd-scaling | ddfd8aee7bd0ccd4c9ac7651918967468996a97e | link | false | /test e2e-azure-ovn-etcd-scaling |
| ci/prow/e2e-aws-ovn-serial-publicnet-1of2 | ddfd8aee7bd0ccd4c9ac7651918967468996a97e | link | false | /test e2e-aws-ovn-serial-publicnet-1of2 |
| ci/prow/e2e-vsphere-ovn-etcd-scaling | ddfd8aee7bd0ccd4c9ac7651918967468996a97e | link | false | /test e2e-vsphere-ovn-etcd-scaling |
| ci/prow/e2e-aws-ovn-cgroupsv2 | ddfd8aee7bd0ccd4c9ac7651918967468996a97e | link | false | /test e2e-aws-ovn-cgroupsv2 |
| ci/prow/e2e-openstack-serial | ddfd8aee7bd0ccd4c9ac7651918967468996a97e | link | false | /test e2e-openstack-serial |
| ci/prow/okd-e2e-gcp | ddfd8aee7bd0ccd4c9ac7651918967468996a97e | link | false | /test okd-e2e-gcp |
| ci/prow/e2e-metal-ipi-serial-ovn-ipv6-2of2 | ddfd8aee7bd0ccd4c9ac7651918967468996a97e | link | false | /test e2e-metal-ipi-serial-ovn-ipv6-2of2 |
| ci/prow/e2e-gcp-disruptive | ddfd8aee7bd0ccd4c9ac7651918967468996a97e | link | false | /test e2e-gcp-disruptive |
| ci/prow/e2e-aws-ovn-etcd-scaling | ddfd8aee7bd0ccd4c9ac7651918967468996a97e | link | false | /test e2e-aws-ovn-etcd-scaling |
| ci/prow/e2e-gcp-ovn-etcd-scaling | ddfd8aee7bd0ccd4c9ac7651918967468996a97e | link | false | /test e2e-gcp-ovn-etcd-scaling |
| ci/prow/e2e-azure-ovn-upgrade | ddfd8aee7bd0ccd4c9ac7651918967468996a97e | link | false | /test e2e-azure-ovn-upgrade |
| ci/prow/e2e-aws-ovn-upgrade-rollback | ddfd8aee7bd0ccd4c9ac7651918967468996a97e | link | false | /test e2e-aws-ovn-upgrade-rollback |
| ci/prow/e2e-aws-ovn-single-node | ddfd8aee7bd0ccd4c9ac7651918967468996a97e | link | false | /test e2e-aws-ovn-single-node |
| ci/prow/e2e-agnostic-ovn-cmd | ddfd8aee7bd0ccd4c9ac7651918967468996a97e | link | false | /test e2e-agnostic-ovn-cmd |
| ci/prow/e2e-vsphere-ovn-dualstack-primaryv6 | ddfd8aee7bd0ccd4c9ac7651918967468996a97e | link | false | /test e2e-vsphere-ovn-dualstack-primaryv6 |
| ci/prow/e2e-aws-ovn-single-node-upgrade | ddfd8aee7bd0ccd4c9ac7651918967468996a97e | link | false | /test e2e-aws-ovn-single-node-upgrade |
| ci/prow/e2e-gcp-fips-serial-2of2 | ddfd8aee7bd0ccd4c9ac7651918967468996a97e | link | false | /test e2e-gcp-fips-serial-2of2 |
| ci/prow/e2e-aws-disruptive | ddfd8aee7bd0ccd4c9ac7651918967468996a97e | link | false | /test e2e-aws-disruptive |
| ci/prow/e2e-gcp-csi | ddfd8aee7bd0ccd4c9ac7651918967468996a97e | link | true | /test e2e-gcp-csi |
| ci/prow/e2e-aws-csi | ddfd8aee7bd0ccd4c9ac7651918967468996a97e | link | true | /test e2e-aws-csi |
| ci/prow/go-verify-deps | ddfd8aee7bd0ccd4c9ac7651918967468996a97e | link | true | /test go-verify-deps |
| ci/prow/e2e-aws-ovn-microshift | ddfd8aee7bd0ccd4c9ac7651918967468996a97e | link | true | /test e2e-aws-ovn-microshift |
| ci/prow/e2e-aws-ovn-microshift-serial | ddfd8aee7bd0ccd4c9ac7651918967468996a97e | link | true | /test e2e-aws-ovn-microshift-serial |
| ci/prow/e2e-metal-ipi-ovn-ipv6 | ddfd8aee7bd0ccd4c9ac7651918967468996a97e | link | true | /test e2e-metal-ipi-ovn-ipv6 |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.