Matthew Booth

Results 389 comments of Matthew Booth

Yep. My motivations for preferring Prow over GH actions are mostly operational, but having nothing remains even more painful. I think we should resurrect the work you already did to...

> I have identified two problems with the loadbalancer and allowedCIDRs logic. > > 1. The first one being the check that waits for the LB to become active again....

Please can you also add a code comment in there about why we're explicitly adding this subnet? Namely because this is the default subnet used by CPO as the origin...

Just needs to be squashed and I'm happy to approve this.

> Well shit. Does it need fixing before merging? Sounds like it, yes.

I don't think it's either, tbh; I think it's a kubernetes question. I know OpenShift can do this, but I'm not 100% clear on the mechanism. It wouldn't surprise me...

> @mdbooth any idea what the difference between conformance and conformance-fast is supposed to be? > > I'm getting the feeling that the "fast" test is not meant to do...