Matthew Booth

Results 389 comments of Matthew Booth

I like this as a problem statement. However, to merge it I think we'd want a discussion of the proposed implementation. There was one at some point. Do you want...

I knew you'd previously created a design doc repo! Lets merge this and I'll update mine to correspond. /lgtm

@EmilienM I'm thinking that the default rules for NodePorts should probably restrict incoming traffic to workers and control plane. Anybody who wants to explicitly expose NodePorts externally with a FIP...

``` error: { Name: "kustomize", Err: { s: "executable file not found in $PATH", }, }, ``` Presumably something somewhere is adding hack/tools/bin to PATH? I couldn't immediately find out...

> Util [functions](https://github.com/kubernetes-sigs/cluster-api/blob/abcc6d85c72aeaa652976f7f7bb341f0db9f4073/util/util.go#L160) in cluster-api v1.11 return v1beta2 objects. Do we expect to use v1beta2 objects in the CAPO releases that are meant for k8s v1.33? Sounds like this is...

The problem is we're trying to call `framework.WithMachineLogCollector` from CAPI , which takes an argument which implements the `ClusterLogCollector` from CAPI. There's only a v1beta2 version of this interface, and...

> @mdbooth What do you think about @fabriziopandini's [comment in the cluster-api PR](https://github.com/kubernetes-sigs/cluster-api/pull/12441#issuecomment-3033248034)? > > Shall we move to v1beta2 manifests (based on cluster-api v1beta2), move controllers to v1beta2 and...

@tormath1 We would probably use cloudbuild rather than GH actions, and I think that *might* support KVM.

That's awesome! I think we're going to need this in cloudbuild for 2 reasons: * We need the artifacts in a GCS bucket for CI or we'll exceed our ingress...