Matthew Booth
Matthew Booth
> Making these changes to the CRD is breaking change which requires a new version of the CRD (probably `v1alpha6`?) Yes, definitely!
However, I do think it's appropriate to make these consistent.
https://github.com/kubernetes-sigs/cluster-api-provider-openstack/pull/1162 should help with this when I eventually get the external CCM config working 😬 Hopefully nearly there.
/assign me /milestone v0.7
/assign mdbooth
Is there any reason you wouldn't just use a bigger root volume?
Is this something you've tested? Did it fix the etcd problem? How would you configure the install image to mount the disk? What volume configuration did you use for improved...
I haven't yet reviewed this properly, but this sounds like something we could cover with an E2E test? For example, in the existing CCM create/delete test, could we provision something...
> /cherry-pick release-0.6 This looks like a nice cleanup, but as @lentzi90 points out I don't think it's actually fixing the bug. I don't think I would backport it.
@jichenjc This looks like a nice cleanup but I don't think this fixes https://github.com/kubernetes-sigs/cluster-api-provider-openstack/issues/1280. Could you remove that from the issue description to avoid it being closed automatically when we...