cluster-api-provider-openstack icon indicating copy to clipboard operation
cluster-api-provider-openstack copied to clipboard

📖 Proposal for microversion support

Open lentzi90 opened this issue 2 years ago • 6 comments

What this PR does / why we need it:

This is a proposal related to #1448 for how to support more microversions in CAPO.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): This is just a proposal so it won't contain the actual implementation.

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • [x] squashed commits
  • if necessary:
    • [x] includes documentation
    • [ ] adds unit tests

/hold

lentzi90 avatar May 26 '23 08:05 lentzi90

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

k8s-ci-robot avatar May 26 '23 08:05 k8s-ci-robot

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar May 26 '23 08:05 k8s-ci-robot

Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
Latest commit a6938bfc0a7c8eb45012b1e580d75d95fc55b76a
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/649031250fb1d90008fa204f
Deploy Preview https://deploy-preview-1565--kubernetes-sigs-cluster-api-openstack.netlify.app/print
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar May 26 '23 08:05 netlify[bot]

I like this as a problem statement. However, to merge it I think we'd want a discussion of the proposed implementation. There was one at some point. Do you want to add it to the doc?

mdbooth avatar Jul 03 '23 10:07 mdbooth

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Jan 20 '24 09:01 k8s-triage-robot

/remove-lifecycle stale

lentzi90 avatar Jan 22 '24 07:01 lentzi90

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Apr 21 '24 07:04 k8s-triage-robot

/remove-lifecycle stale

lentzi90 avatar Apr 22 '24 05:04 lentzi90

I knew you'd previously created a design doc repo! Lets merge this and I'll update mine to correspond.

/lgtm

mdbooth avatar Apr 30 '24 10:04 mdbooth

Thanks! /hold cancel

lentzi90 avatar Apr 30 '24 12:04 lentzi90